Amp-bind: Move integration test from test-bind-impl to test-bind-integrations #8010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmh287
force-pushed
the
bind_integration_cleanup
branch
from
90e06e0
to
8ab922d
Compare
kmh287
force-pushed
the
bind_integration_cleanup
branch
from
bd35b0d
to
b9c6004
Compare
|
@choumx good to go? |
dreamofabear
approved these changes
Mar 20, 2017
| @@ -64,6 +64,39 @@ describe.configure().retryOnSaucelabs().run('amp-bind', function() { | |||
| waitForEvent('amp:bind:setState')); | |||
| } | |||
|
|
|||
| function waitForAllMutations() { | |||
There was a problem hiding this comment.
Nit: Add /** @return {!Promise} */
jpettitt
pushed a commit
to jpettitt/amphtml
that referenced
this pull request
Mar 21, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved an integration test to the new test-bind-integrations test.
/to @choumx @jridgewell