Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a redundant CSI ping #8023

Merged
merged 1 commit into from Mar 17, 2017
Merged

Conversation

tdrl
Copy link

@tdrl tdrl commented Mar 8, 2017

Removes a CSI ping that is being issued twice: once at the beginning of layoutCallback and once in renderNonAmpCreative_.

@tdrl
Copy link
Author

tdrl commented Mar 17, 2017

@lannka Friendly ping, in case you didn't notice this one before.

@lannka lannka self-assigned this Mar 17, 2017
@ampprojectbot
Copy link
Member

Hi, ampproject bot here! Here are a list of the owners that can approve your files.

You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status

/to ampproject/a4a

  • extensions/amp-a4a/0.1/amp-a4a.js

For any issues please file a bug at https://github.com/google/github-owners-bot/issues

@lannka lannka merged commit 150e123 into ampproject:master Mar 17, 2017
@tdrl tdrl deleted the a4a_double_csi_ping_fix branch March 20, 2017 11:37
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants