Fix form test flakiness #8096
Merged
Fix form test flakiness #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files.
|
jridgewell
requested changes
Mar 13, 2017
extensions/amp-form/0.1/amp-form.js
Outdated
| }); | ||
| }); | ||
| this.xhrSubmitPromise_ = p; |
There was a problem hiding this comment.
Let's only set this in test mode, Closure can eliminate the property in prod, then.
erwinmombay
previously approved these changes
Mar 13, 2017
erwinmombay
requested review from
erwinmombay
and removed request for
erwinmombay
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to @aghassemi
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
aghassemi
suggested changes
Mar 14, 2017
extensions/amp-form/0.1/amp-form.js
Outdated
| @@ -366,8 +370,12 @@ export class AmpForm { | |||
| /** @type {../../../src/service/xhr-impl.FetchResponse} */ ( | |||
| error)); | |||
| rethrowAsync('Form submission failed:', error); | |||
| return error; | |||
There was a problem hiding this comment.
remove, we are not using this.
jridgewell
approved these changes
Mar 14, 2017
aghassemi
approved these changes
Mar 14, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the flakiness in test-amp-form.
It seems unnecessary for the test to check if the error was thrown async. It should be enough to check that the error template was rendered.
Fixes #7962