Send RTV version number along with CSI pings. #8111
Conversation
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status
|
| @@ -302,6 +303,10 @@ export class Performance { | |||
| return this.enabledExperiments_; | |||
| } | |||
| const experiments = []; | |||
| // Add RTV version as experiment ID, so we can slice the data by version. | |||
| if (getMode(this.win).rtvVersion) { | |||
| experiments.push(getMode(this.win).rtvVersion); | |||
There was a problem hiding this comment.
Does this really belong in the ampexp field?
There was a problem hiding this comment.
That's the field CSI already supports. We may separate it later.
There was a problem hiding this comment.
i think we probably stick with ampexp. we are not supposed to introduce arbitrary new param to CSI (which is shared by many other Google products).
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to dvoytenko jridgewell
/to alanorozco aghassemi cvializ chenshay honeybadgerdontcare dvoytenko ericlindley-g erwinmombay gregable lannka mrjoro powdercloud newmuis jridgewell kmh287 cramforce mkhatib camelburrito choumx muxin zhouyx
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
* Send RTV version number along with CSI pings. * fix tests
* Send RTV version number along with CSI pings. * fix tests
* Send RTV version number along with CSI pings. * fix tests
* Send RTV version number along with CSI pings. * fix tests
No description provided.