Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup level1 -amp-element classes #8130

Merged
merged 1 commit into from Mar 14, 2017
Merged

Cleanup level1 -amp-element classes #8130

merged 1 commit into from Mar 14, 2017

Conversation

dvoytenko
Copy link
Contributor

Cleanup is confirmed. These declarations can be finally removed.

Closes #8091

@erwinmombay
Copy link
Member

erwinmombay commented Mar 14, 2017 •
edited

@dvoytenko do all -amp- prefix classes need to be removed? guessing this is just for core, since i see a bunch of extensions use -amp-

@dvoytenko
Copy link
Contributor Author

@erwinmombay Not yet. Still some less often used stay. Remainder is tracked here: #6463.

@dvoytenko dvoytenko merged commit a76e68b into ampproject:master Mar 14, 2017
@dvoytenko dvoytenko deleted the fixes123 branch March 14, 2017 21:05
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
@mrjoro
Cleanup level1 -amp-element classes (ampproject#8130)
a3cbd43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

@aghassemi aghassemi Awaiting requested review from aghassemi

Assignees

@erwinmombay erwinmombay

@aghassemi aghassemi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvoytenko @erwinmombay @aghassemi