Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator Rollup #8134

Closed
wants to merge 12 commits into from
Closed

Validator Rollup #8134

wants to merge 12 commits into from

Conversation

Gregable
Copy link
Member

No description provided.

powdercloud and others added 12 commits March 14, 2017 14:41
@powdercloud
Fix typo: dumpSaxAsJson should correspond to provide.
c9a63d2
@honeybadgerdontcare
Revision bump
6a3977a
@honeybadgerdontcare
Revision bump
6902027
Update spec urls to more canonical location.
33d07b4
Add a test case for <amp-ad>
f48fc4b
Emit one error per attribute, rather than stop at the first error fou…
e3564a1 
…nd for any attribute in an HTML tag.
Allow <iframe> tag within <noscript> section, suggesting `<amp-if…
27ce1b9 
…rame>` in other contexts.
Revision bump for <amp-facebook-comments>.
a57dfc9
Error categorization had a conditional branch which no longer could b…
e4497cb 
…e reached, due to changes to the way we generated errors. This CL removes that extra code.
@honeybadgerdontcare
Revision bump, and updates to amp-nexxtv-player.
3c7a4c3
@honeybadgerdontcare
Revision bump
766f176
@honeybadgerdontcare
Blacklist meta name=(amp-.*|amp4ads-.*) and whitelist specific instan…
72bce30 
…ces.
@ampprojectbot
Copy link
Member

Hi, ampproject bot here! Here are a list of the owners that can approve your files.

You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status

/to cramforce dvoytenko

  • extensions/amp-ad/0.1/test/validator-amp-ad.html
  • extensions/amp-ad/0.1/test/validator-amp-ad.out
  • extensions/amp-ad/0.1/validator-amp-ad.protoascii
  • extensions/amp-anim/0.1/validator-amp-anim.protoascii
  • extensions/amp-audio/0.1/test/validator-amp4ads-amp-audio.out
  • extensions/amp-audio/0.1/validator-amp-audio.protoascii
  • extensions/amp-brid-player/0.1/test/validator-amp-brid-player.out
  • extensions/amp-brid-player/0.1/validator-amp-brid-player.protoascii
  • extensions/amp-brightcove/0.1/test/validator-amp-brightcove.out
  • extensions/amp-brightcove/0.1/validator-amp-brightcove.protoascii
  • extensions/amp-call-tracking/0.1/test/validator-amp-call-tracking.out
  • extensions/amp-call-tracking/0.1/validator-amp-call-tracking.protoascii
  • extensions/amp-carousel/0.1/test/validator-amp-carousel.out
  • extensions/amp-carousel/0.1/validator-amp-carousel.protoascii
  • extensions/amp-dynamic-css-classes/0.1/validator-amp-dynamic-css-classes.protoascii
  • extensions/amp-experiment/0.1/test/validator-amp-experiment.out
  • extensions/amp-experiment/0.1/validator-amp-experiment.protoascii
  • extensions/amp-facebook-comments/0.1/validator-amp-facebook-comments.protoascii
  • extensions/amp-facebook/0.1/validator-amp-facebook.protoascii

/to dvoytenko

  • extensions/amp-access/0.1/validator-amp-access.protoascii

/to camelburrito

  • extensions/amp-accordion/0.1/test/validator-amp-accordion.out
  • extensions/amp-accordion/0.1/validator-amp-accordion.protoascii

/to avimehta dvoytenko

  • extensions/amp-analytics/0.1/validator-amp-analytics.protoascii

/to mrsufgi

  • extensions/amp-apester-media/0.1/validator-amp-apester-media.protoascii

/to aghassemi

  • extensions/amp-app-banner/0.1/test/validator-amp-app-banner-missing-meta.out
  • extensions/amp-app-banner/0.1/validator-amp-app-banner.protoascii

/to choumx kmh287

  • extensions/amp-bind/0.1/test/validator-amp-bind.out
  • extensions/amp-bind/0.1/validator-amp-bind.protoascii

/to zeno erwinmombay aghassemi

  • extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.out
  • extensions/amp-dailymotion/0.1/validator-amp-dailymotion.protoascii

For any issues please file a bug at https://github.com/google/github-owners-bot/issues

@ampprojectbot
Copy link
Member

Hi, ampproject bot here! Here are a list of the owners that can approve your files.

You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status

/to cramforce dvoytenko

  • extensions/amp-ad/0.1/test/validator-amp-ad.html
  • extensions/amp-ad/0.1/test/validator-amp-ad.out
  • extensions/amp-ad/0.1/validator-amp-ad.protoascii
  • extensions/amp-anim/0.1/validator-amp-anim.protoascii
  • extensions/amp-audio/0.1/test/validator-amp4ads-amp-audio.out
  • extensions/amp-audio/0.1/validator-amp-audio.protoascii
  • extensions/amp-brid-player/0.1/test/validator-amp-brid-player.out
  • extensions/amp-brid-player/0.1/validator-amp-brid-player.protoascii
  • extensions/amp-brightcove/0.1/test/validator-amp-brightcove.out
  • extensions/amp-brightcove/0.1/validator-amp-brightcove.protoascii
  • extensions/amp-call-tracking/0.1/test/validator-amp-call-tracking.out
  • extensions/amp-call-tracking/0.1/validator-amp-call-tracking.protoascii
  • extensions/amp-dynamic-css-classes/0.1/validator-amp-dynamic-css-classes.protoascii
  • extensions/amp-experiment/0.1/test/validator-amp-experiment.out
  • extensions/amp-experiment/0.1/validator-amp-experiment.protoascii
  • extensions/amp-facebook-comments/0.1/validator-amp-facebook-comments.protoascii
  • extensions/amp-facebook/0.1/validator-amp-facebook.protoascii

/to dvoytenko

  • extensions/amp-access/0.1/validator-amp-access.protoascii

/to camelburrito

  • extensions/amp-accordion/0.1/test/validator-amp-accordion.out
  • extensions/amp-accordion/0.1/validator-amp-accordion.protoascii

/to avimehta dvoytenko

  • extensions/amp-analytics/0.1/validator-amp-analytics.protoascii

/to mrsufgi

  • extensions/amp-apester-media/0.1/validator-amp-apester-media.protoascii

/to aghassemi

  • extensions/amp-app-banner/0.1/test/validator-amp-app-banner-missing-meta.out
  • extensions/amp-app-banner/0.1/validator-amp-app-banner.protoascii

/to choumx kmh287

  • extensions/amp-bind/0.1/test/validator-amp-bind.out
  • extensions/amp-bind/0.1/validator-amp-bind.protoascii

/to camelburrito dvoytenko

  • extensions/amp-carousel/0.1/test/validator-amp-carousel.out
  • extensions/amp-carousel/0.1/validator-amp-carousel.protoascii

/to zeno erwinmombay aghassemi

  • extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.out
  • extensions/amp-dailymotion/0.1/validator-amp-dailymotion.protoascii

For any issues please file a bug at https://github.com/google/github-owners-bot/issues

@powdercloud powdercloud mentioned this pull request Mar 14, 2017
Closed
@Gregable Gregable closed this Mar 14, 2017
@Gregable Gregable deleted the rollup branch March 14, 2017 22:15
@powdercloud powdercloud mentioned this pull request Mar 14, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powdercloud powdercloud powdercloud approved these changes

@honeybadgerdontcare honeybadgerdontcare Awaiting requested review from honeybadgerdontcare

Assignees
No one assigned
Labels
WG: caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gregable @ampprojectbot @powdercloud @honeybadgerdontcare