Patch #7984 - extended snowplow analytics

[ecoron]

• extends amp-analytics vendor snowplow by adding more possible properties.

Closes #7984.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[ampprojectbot]

Hi, ampproject bot here! Here are a list of the owners that can approve your files.

You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status

/to avimehta dvoytenko

• extensions/amp-analytics/0.1/test/vendor-requests.json
• extensions/amp-analytics/0.1/vendors.js

For any issues please file a bug at https://github.com/google/github-owners-bot/issues

[ecoron]

I signed it!

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

[ecoron]

alternative address is signed too

[googlebot]

CLAs look good, thanks!

[ecoron]

@ampprojectbot retry!

[jridgewell]

Hi @ecoron, you'll need to rebase the pull request for our CI tester to pass. See the instructions here: https://github.com/ampproject/amphtml/blob/733281f57b7949e03930e2a4ae0d2d4741ee5b5c/contributing/getting-started-e2e.md#pull-the-latest-changes-from-the-amphtml-repository

[ecoron]

i did it, sorry for delay.

[lannka]

clientId takes a required param as scope (cookie name). this right now throws exception on the analytics-vendors.amp.html example page. @ecoron could you fix that?

/cc @avimehta

[lannka]

Filed an issue for this: #9383

[ecoron]

Hi, yes i can take a look on it.