Force AMP pages to always paint once before installing extensions. #8231
Conversation
This makes AMP draw roughly half way into the JS initialization which is quite significant perceptual speedup. This comes at - overall larger CPU usage (due to extra paint and more style recalc) - and overall slightly longer start up (since waiting for frames to pass by).
|
Screenshot showing how a frame is pumped while JS is still super busy. Without the change
|
|
PTAL. Added handling for extensions coming in while waiting on a frame and added tests. |
cramforce
force-pushed
the
benchmarking-march-2017
branch
from
b652786
to
69922bc
Compare
cramforce
force-pushed
the
benchmarking-march-2017
branch
from
69922bc
to
c25cfd1
Compare
…as we don't usually want to render early if these are present.
|
Added presence of render delaying services as a bailout condition, since we need them to run ASAP. |
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to cramforce dvoytenko jridgewell
/to dvoytenko jridgewell
/to alanorozco camelburrito chenshay choumx cvializ ericlindley-g erwinmombay gregable honeybadgerdontcare jridgewell kmh287 lannka mkhatib mrjoro muxin newmuis powdercloud zhouyx
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
|
LGTM |
cramforce
changed the title
…mpproject#8231) This makes AMP draw roughly half way into the JS initialization which is quite significant perceptual speedup. This comes at - overall larger CPU usage (due to extra paint and more style recalc) - and overall slightly longer start up (since waiting for frames to pass by).
This makes AMP draw roughly half way into the JS initialization which is quite significant perceptual speedup. This comes at