Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the Windows check back into the nodejs validator module and bump revision for release. #8276

Merged
merged 1 commit into from Mar 20, 2017

Conversation

powdercloud
Copy link
Contributor

Also a comment for the DELETEME file.

we can push to NPM. Also a comment for the DELETEME file.
@powdercloud
Copy link
Contributor Author

/cc: @xavierleune
Thanks again for helping out with this. I'm about to release this one.

Copy link
Contributor

@honeybadgerdontcare honeybadgerdontcare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powdercloud powdercloud merged commit 2ce4528 into ampproject:master Mar 20, 2017
@powdercloud powdercloud deleted the nodejs branch March 21, 2017 06:44
@xavierleune
Copy link
Contributor

A big thank to @powdercloud !

mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
…ject#8276)

we can push to NPM. Also a comment for the DELETEME file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants