Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up docs for new components #8300

Merged
1 commit merged into from Mar 21, 2017
Merged

Clean up docs for new components #8300

1 commit merged into from Mar 21, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2017

New components were introduced and I've cleaned up the docs for clarity and consistency.

@ghost ghost requested a review from aghassemi March 21, 2017 20:43
@ampprojectbot
Copy link
Member

Hi, ampproject bot here! Here are a list of the owners that can approve your files.

You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status

/to cramforce dvoytenko jridgewell

  • extensions/amp-facebook-comments/amp-facebook-comments.md
  • extensions/amp-fx-parallax/amp-fx-parallax.md
  • extensions/amp-nexxtv-player/amp-nexxtv-player.md

For any issues please file a bug at https://github.com/google/github-owners-bot/issues

@ghost ghost merged commit 54977e0 into ampproject:master Mar 21, 2017
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
@cvrlebg
Copy link

cvrlebg commented May 11, 2017

Hi, can you add new attribute something like data-locale for facebook comments, where we can put language code (eg. fr_FR)? This will be very useful for non-english sites.

@ghost
Copy link
Author

ghost commented May 11, 2017

@cvrlebg - Is this a request to add the data-locale attribute to the amp-facebook-comments component? If so, this isn't the correct place to ask. Please file an issue with your suggestion.

@cvrlebg
Copy link

cvrlebg commented May 11, 2017

@bpaduch Yes, sorry and thank you. :)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants