Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix of attribute description #8454

Merged
merged 1 commit into from Apr 30, 2017
Merged

Minor fix of attribute description #8454

merged 1 commit into from Apr 30, 2017

Conversation

alfredmyers
Copy link
Contributor

@alfredmyers alfredmyers commented Mar 28, 2017 •
edited

On the description for sizes attribute, where read:

sizes

Same as srcset attribute on the img tag. For more information see the common sizes attribute docs.

should read:

sizes

Same as sizes attribute on the img tag. For more information see the common sizes attribute docs.

@alfredmyers
Minor fix of attribute description
4a19d31 
On the description for `sizes` attribute, where read:

> **sizes**
> 
> Same as `srcset` attribute on the `img` tag. For more information see the [common `sizes` attribute docs](../spec/amp-html-layout.md#sizes).

should read:

> **sizes**
> 
> Same as `sizes` attribute on the `img` tag. For more information see the [common `sizes` attribute docs](../spec/amp-html-layout.md#sizes).
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@alfredmyers
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@alfredmyers
Copy link
Contributor Author

bump

dreamofabear
dreamofabear approved these changes Apr 30, 2017
View reviewed changes
Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! /cc @bpaduch

@dreamofabear dreamofabear merged commit 21c7618 into ampproject:master Apr 30, 2017
@alfredmyers alfredmyers deleted the patch-2 branch April 30, 2017 21:34
KenneyE pushed a commit to spotxchange/amphtml that referenced this pull request May 3, 2017
@alfredmyers
Minor fix of attribute description (ampproject#8454)
eddedcb 
On the description for `sizes` attribute, where read:

> **sizes**
> 
> Same as `srcset` attribute on the `img` tag. For more information see the [common `sizes` attribute docs](../spec/amp-html-layout.md#sizes).

should read:

> **sizes**
> 
> Same as `sizes` attribute on the `img` tag. For more information see the [common `sizes` attribute docs](../spec/amp-html-layout.md#sizes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alfredmyers @googlebot @dreamofabear @ampprojectbot @ampwafflebot