New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update action documentation to include new input data #8633
Conversation
spec/amp-actions-and-events.md
Outdated
</tr> | ||
<tr> | ||
<td>change</td> | ||
<td>Fired when the value of the element is changed.</td> | ||
<td> Various, see below.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove extra space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -102,10 +102,36 @@ Including: `input[type=radio]`, `input[type=checkbox]` and `select`. | |||
<tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a line above that says: "Including: input[type=radio]
, input[type=checkbox]
and select
." Let's add range
to it explicitly as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Updating documentation based on the changes in #8569
Documentation for features requested in #7765
/to @aghassemi @bpaduch