amp-bind: Fix [class] verification #8717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmh287
approved these changes
Apr 12, 2017
| if (AMP_CSS_RE.test(cssClass)) { | ||
| initialValue.push(cssClass); | ||
| continue; |
There was a problem hiding this comment.
Nit: Save a line by flipping the condition and putting the push inside the if-statement. (The comment makes the inverted condition easily readable)
There was a problem hiding this comment.
Wanted to be more explicit since the lack of the ! was the source of the bug.
| it('should verify class bindings in dev mode', () => { | ||
| window.AMP_MODE = {development: true}; | ||
| createElementWithBinding(`[class]="'foo'" class="foo"`); // No error. | ||
| createElementWithBinding(`[class]="'bar'"`); // Error. |
There was a problem hiding this comment.
nit: Please make the reason for the error more explicit in the test. Some ways to do this could be adding a comment that the values need to match or changing the second element to have an explicitly incorrect value for class
dreamofabear
force-pushed
the
bind-verify-class
branch
from
5629c39
to
fa3c8c2
Compare
DarXector
pushed a commit
to DarXector/amphtml
that referenced
this pull request
Apr 25, 2017
* fix class verification in amp-bind * kevin's comment
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* fix class verification in amp-bind * kevin's comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8716.
/to @kmh287