amp-bind: Expose encodeURI and encodeURIComponent in bind #8723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -268,6 +268,11 @@ describe('BindExpression', () => { | |||
| }).to.throw(unsupportedFunctionError); | |||
| }); | |||
|
|
|||
| it('should support encodeURI and encodeURIComponent', () => { | |||
| expect(evaluate('encodeURI("Hello World")')).to.equal('Hello%20World'); | |||
| expect(evaluate('encodeURIComponent("#foo=bar")')).to.equal('%23foo%3Dbar'); | |||
There was a problem hiding this comment.
Is this a fragment or URL params? We should test the latter.
kmh287
commented
Apr 13, 2017
| @@ -268,6 +268,11 @@ describe('BindExpression', () => { | |||
| }).to.throw(unsupportedFunctionError); | |||
| }); | |||
|
|
|||
| it('should support encodeURI and encodeURIComponent', () => { | |||
| expect(evaluate('encodeURI("Hello World")')).to.equal('Hello%20World'); | |||
| expect(evaluate('encodeURIComponent("#foo=bar")')).to.equal('%23foo%3Dbar'); | |||
dreamofabear
approved these changes
Apr 13, 2017
| expect(evaluate('encodeURI("http://www.google.com/s p a c e.html")')) | ||
| .to.equal('http://www.google.com/s%20p%20a%20c%20e.html'); | ||
| expect(evaluate('encodeURIComponent("hello world")')) | ||
| .to.equal('hello%20world'); |
There was a problem hiding this comment.
Nit: This test for encodeURIComponent tests the same functionality as the one for encodeURI. Recommend testing proper encoding for some of these chars: ; , / ? : @ & = + $ #
There was a problem hiding this comment.
I'm not sure that's necessary. We don't need to test the correctness of the functions, just that using them in bind expressions works.
There was a problem hiding this comment.
Correctness is currently an implementation detail. 😄 It is a nitpick though.
DarXector
pushed a commit
to DarXector/amphtml
that referenced
this pull request
Apr 25, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
encodeURIandencodeURIComponentin bind.Partial for #8700
/to @choumx