Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taboola: fixing typo. the Taboola script supports type "other" not "others". #8744

Merged

Conversation

michaeld79
Copy link
Contributor

@michaeld79 michaeld79 commented Apr 13, 2017

The Taboola script supports type "other" not "others".
code with "data-others" will not load the Taboola widget.

fix for issue : #8585

cc : @zhouyx

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@zhouyx
Copy link
Contributor

zhouyx commented Apr 13, 2017

Hmm CLA. I thought it passed last time.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
@michaeld79 Did you change your email address?

@michaeld79
Copy link
Contributor Author

michaeld79 commented Apr 13, 2017

@zhouyx no, for some reason the email was not setup in the git commit.
so i think its missing an author. how do i fix it?

@zhouyx
Copy link
Contributor

zhouyx commented Apr 13, 2017

Ah so this email account hasn't signed CLA before. Would you mind switch the email account?

@michaeld79
Copy link
Contributor Author

michaeld79 commented Apr 13, 2017

@zhouyx switched the public account to the taboola one. should i do anything else?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@zhouyx
Copy link
Contributor

zhouyx commented Apr 13, 2017

Unfortunately googlebot would need the pull request author and commit author to both sign the CLA. @michaeld79 I know this is annoying, but could you commit with your taboola account as well. There is not much thing I can do to with the googlebot here. Thanks alot!

@michaeld79
Copy link
Contributor Author

michaeld79 commented Apr 13, 2017

@zhouyx added commit with the good email

Squashed commits:
[c067c83] fix typo
[62735f5] fixing typo.

The Taboola script supports type "other" not "others".
code with "data-others" will not load the Taboola widget.
@michaeld79 michaeld79 force-pushed the taboola_other_pagetype_typo_fix branch from 0684f47 to 2333bdd Compare April 14, 2017 04:02
@googlebot
Copy link

CLAs look good, thanks!

@michaeld79
Copy link
Contributor Author

@zhouyx all green now

@zhouyx zhouyx merged commit 657f5db into ampproject:master Apr 14, 2017
@zhouyx
Copy link
Contributor

zhouyx commented Apr 14, 2017

@michaeld79 🎉 Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants