New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taboola: fixing typo. the Taboola script supports type "other" not "others". #8744
Taboola: fixing typo. the Taboola script supports type "other" not "others". #8744
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Hmm CLA. I thought it passed last time.
|
@zhouyx no, for some reason the email was not setup in the git commit. |
Ah so this email account hasn't signed CLA before. Would you mind switch the email account? |
@zhouyx switched the public account to the taboola one. should i do anything else? |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Unfortunately googlebot would need the pull request author and commit author to both sign the CLA. @michaeld79 I know this is annoying, but could you commit with your taboola account as well. There is not much thing I can do to with the googlebot here. Thanks alot! |
@zhouyx added commit with the good email |
Squashed commits: [c067c83] fix typo [62735f5] fixing typo. The Taboola script supports type "other" not "others". code with "data-others" will not load the Taboola widget.
0684f47
to
2333bdd
Compare
CLAs look good, thanks! |
@zhouyx all green now |
@michaeld79 🎉 Merged! |
The Taboola script supports type "other" not "others".
code with "data-others" will not load the Taboola widget.
fix for issue : #8585
cc : @zhouyx