Don't depend on formatting args in error message in amp-list#layoutCallback #8818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
reviewed
Apr 18, 2017
extensions/amp-list/0.1/amp-list.js
Outdated
| @@ -57,7 +60,8 @@ export class AmpList extends AMP.BaseElement { | |||
| return templatesFor(this.win).findAndRenderTemplateArray( | |||
| this.element, items).then(this.rendered_.bind(this)); | |||
| }, error => { | |||
| user().assert(false, error.message, this.element); | |||
| user().error(TAG, | |||
There was a problem hiding this comment.
Let's make sure that catch itself fails:
throw user().createError('Error fetching amp-list', ..., error, ...);
dvoytenko
approved these changes
Apr 18, 2017
zhouyx
pushed a commit
that referenced
this pull request
Apr 18, 2017
DarXector
pushed a commit
to DarXector/amphtml
that referenced
this pull request
Apr 25, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that caused amp-list to send a string to log#assert with fewer string placeholders than provided arguments.
Fixes #8814
/to @dvoytenko Let me know if you want me to update the assert function to better handle this situation.