Simplify parseQueryString #8877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
reviewed
Apr 21, 2017
| let match; | ||
| while ((match = regex.exec(queryString))) { | ||
| const name = decodeURIComponent(match[1]).trim(); | ||
| const value = match[2] ? decodeURIComponent(match[2]).trim() : ''; |
There was a problem hiding this comment.
Just realized that trimming the result of decode is probably a wrong thing :( Maybe we should do it in a separate PR, but x=value%20 should probably preserve a space in the value? Trimming pre-decoded strings is certainly fine...
There was a problem hiding this comment.
I'm kinda of the opinion we shouldn't trim at all. We can definitely discuss this in a separate PR, though.
There was a problem hiding this comment.
Yeah. I'm leaning toward that as well. Not trimming is better than trimming in this case.
DarXector
pushed a commit
to DarXector/amphtml
that referenced
this pull request
Apr 25, 2017
* Simplify parseQueryString https://jsperf.com/parsing-query-string * Remove unused import
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* Simplify parseQueryString https://jsperf.com/parsing-query-string * Remove unused import
KenneyE
pushed a commit
to spotxchange/amphtml
that referenced
this pull request
May 3, 2017
* Simplify parseQueryString https://jsperf.com/parsing-query-string * Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And it's faster.