Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing ibeatAnalytics tracking API URL domain name chang #8888

Merged
merged 1 commit into from Apr 26, 2017

Conversation

NitendraKumar
Copy link
Contributor

There is a requirement to change the domain name from ibeats to ibeat. changed it in all files

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@NitendraKumar
Copy link
Contributor Author

Hi @jridgewell ,
Thank you so much for your quick reply on my issue.
As per your suggestion I have delete the old repository, forked new from master project and finally push my changes.
Your suggestion is really helpful.
Please review my changes.
Thank

@NitendraKumar
Copy link
Contributor Author

I signed it!
with mail id : nitinjnumca09@gmail.com

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@jridgewell jridgewell requested review from zhouyx and lannka and removed request for zhouyx April 22, 2017 20:53
@NitendraKumar
Copy link
Contributor Author

Hi @lannka @jridgewell ,

Please review the code change of Analytics API.
We are about to enable analytics tracking in AMP pages on our website and waiting for final URL integration.

Please Review and merge above change in master project.
Thanks

@jridgewell
Copy link
Contributor

We have an issue with the CLA. Seems the commit was authored with nitendra.kumar@timesinternet.in, but that's not the email used in the CLA.

@NitendraKumar
Copy link
Contributor Author

NitendraKumar commented Apr 26, 2017

Hi @jridgewell ,
Thank you so much for review and approval of my pull request.
I have logged in GITHUB using nitinjnumca09@gmail.com, created repository and committed the code using my gmail id.
I did not used nitendra.kumar@timesinternet.in any where in integration process.
After clicking on https://cla.developers.google.com/ CLA page says I am already sign the CLA.
Please have a look on attached image of my CLA agreement page.
cla
Please guide to resolve the CLA issue.

@jridgewell
Copy link
Contributor

I did not used nitendra.kumar@timesinternet.in any where in integration process.

This is from Github's interface:
screen shot 2017-04-26 at 1 48 23 pm

@erwinmombay: Can you force merge?

@erwinmombay erwinmombay merged commit 1b5ccaa into ampproject:master Apr 26, 2017
@NitendraKumar
Copy link
Contributor Author

Hi @jridgewell @erwinmombay ,

Thanks for your guidance and support throughout the integration process of ibeatAnalytics.
You guys make this process really simple simple.

Thanks once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants