Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client id scope to ezoic ad config. #8909

Merged
merged 1 commit into from Apr 26, 2017

Conversation

superbaddude
Copy link
Contributor

@superbaddude superbaddude commented Apr 24, 2017

Added client id scope to ezoic ad config.

Closes #8908

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@superbaddude
Copy link
Contributor Author

I signed it!

@superbaddude
Copy link
Contributor Author

superbaddude commented Apr 24, 2017 via email

@dynes
Copy link
Contributor

dynes commented Apr 26, 2017

Is there something else that we need to do in order for this to get approved? The CLA has been signed for the company, I'm not sure why it is unable to verify.

@jridgewell
Copy link
Contributor

@dynes: This was committed using the email rsmith@ezoic.com, but that does not appear on the corporate CLA you signed. Please edit the CLA to add the email.

@superbaddude
Copy link
Contributor Author

@jridgewell rsmith@ezoic.com is part of the company Ezoic Inc, and we are not allowed to sign the CLA a second time. how do we add that email address to the company CLA?

@jridgewell
Copy link
Contributor

You should be able to edit it. /cc @mrjoro

@superbaddude
Copy link
Contributor Author

@jridgewell Authorization is via a google group, which rsmith@ezoic.com is a member of. However, membership for the group was made private. I made it public. Is that enough? /cc @mrjoro

@jridgewell
Copy link
Contributor

Um, try saying "I signed it!" again.

@dynes
Copy link
Contributor

dynes commented Apr 26, 2017

I signed it! Company: Ezoic Inc

1 similar comment
@superbaddude
Copy link
Contributor Author

I signed it! Company: Ezoic Inc

@jridgewell
Copy link
Contributor

@erwinmombay: Please force merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants