better error message #8913
Merged
better error message #8913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
reviewed
Apr 24, 2017
| @@ -274,8 +274,8 @@ export class Messaging { | |||
| handler = this.defaultHandler_; | |||
| } | |||
| if (!handler) { | |||
| throw new Error( | |||
| 'Cannot handle request because handshake is not yet confirmed!'); | |||
| throw new Error('Cannot handle request ' + message.name + | |||
There was a problem hiding this comment.
It's better to use args, like this:
const error = new Error('Cannot handle ....');
error.args = request.name;
This way, we will be able to group errors by the message "Cannot handle..." and get a good total number, but still will be able to find the actual request name if we need to.
dvoytenko
approved these changes
Apr 24, 2017
DarXector
pushed a commit
to DarXector/amphtml
that referenced
this pull request
Apr 25, 2017
* better error message * error
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* better error message * error
KenneyE
pushed a commit
to spotxchange/amphtml
that referenced
this pull request
May 3, 2017
* better error message * error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding message name in the error message