ignore any error that has stop_youtube #8914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also ran gofmt to fix formatting inconsistencies |
dvoytenko
reviewed
Apr 24, 2017
tools/errortracker/errortracker.go
Outdated
| strings.Contains(event.Exception, "stop_youtube") { | ||
| w.Header().Set("Content-Type", "text/plain; charset=utf-8") | ||
| w.WriteHeader(http.StatusOK) | ||
| fmt.Fprintln(w, "IGNORE\n") |
There was a problem hiding this comment.
Should not we still return No_CONTENT?
There was a problem hiding this comment.
that is probably better
erwinmombay
force-pushed
the
filter-youtube
branch
from
9934a9c
to
a8e60c3
Compare
|
@dvoytenko can you review again? |
dvoytenko
approved these changes
Apr 27, 2017
|
Version bump? |
erwinmombay
force-pushed
the
filter-youtube
branch
from
a8e60c3
to
9ce1ab5
Compare
|
@jridgewell done |
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
KenneyE
pushed a commit
to spotxchange/amphtml
that referenced
this pull request
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8915.