New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default aria-live attributes to amp-live-list and amp-fresh #8988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
@@ -255,6 +255,22 @@ describe('amp-live-list', () => { | |||
}).to.throw(/must have an "items" slot/); | |||
}); | |||
|
|||
it('should have aria-live=polite by default', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actual code is testing the override case though (same issue with test-amp-fresh.js as well) Let's have two tests, one for default and one for override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR gives these elements
aria-live=polite
by default, but allows this to be explicitly overridden by developers.Fixes #5512
/to @aghassemi