amp-bind: Delay init until viewer first visible #9033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Apr 28, 2017
dvoytenko
approved these changes
Apr 28, 2017
|
LGTM, but the question I have: is this purely a performance thing? Or more related to prerender privacy? If the latter, we must have tests for this. |
|
@dvoytenko Just a performance thing to reduce potential impact on SRP. |
jridgewell
pushed a commit
that referenced
this pull request
Apr 28, 2017
* make bind wait until viewer visible * fix lint * fix tests
KenneyE
pushed a commit
to spotxchange/amphtml
that referenced
this pull request
May 3, 2017
* make bind wait until viewer visible * fix lint * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9032. Will follow up with unit tests.
/to @dvoytenko @jridgewell