Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit saucelabs concurrent browsers launched #9041

Merged
merged 1 commit into from Apr 28, 2017

Conversation

muxin
Copy link
Contributor

@muxin muxin commented Apr 28, 2017

related to #9030
trying out solving saucelabs disconnected issue

@muxin muxin requested a review from jridgewell April 28, 2017 20:38
@muxin
Copy link
Contributor Author

muxin commented Apr 28, 2017

@jridgewell I'm not sure whether this will help. Do you know how I can trigger the saucelabs test before merging to master?

@jridgewell
Copy link
Contributor

What is the default concurrency?

@muxin
Copy link
Contributor Author

muxin commented Apr 28, 2017

infinity

@muxin
Copy link
Contributor Author

muxin commented Apr 28, 2017

FYI karma-runner/karma#1646

jridgewell
jridgewell previously approved these changes Apr 28, 2017
@jridgewell jridgewell dismissed their stale review April 28, 2017 21:54

Sorry, @erwinmombay should really approve this.

@erwinmombay
Copy link
Member

lol infinity

@erwinmombay erwinmombay reopened this Apr 28, 2017
@muxin muxin merged commit a155b95 into ampproject:master Apr 28, 2017
@muxin muxin deleted the saucelabs-concurrency branch April 28, 2017 22:41
KenneyE pushed a commit to spotxchange/amphtml that referenced this pull request May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants