Improve localhost link filtering in markdown during pr-check.js #9207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
approved these changes
May 8, 2017
| * @return {string} Markdown after filtering out localhost links. | ||
| */ | ||
| function filterLocalhostLinks(markdown) { | ||
| var localhostPattern = 'http:\/\/localhost:8000'; |
There was a problem hiding this comment.
can be merged into a single regex, feel free to add TODO + issue to tackle soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On further testing, some inline links in markdown were slipping through, causing false negatives in "gulp check-links". This PR goes through the two kinds of markdown elements that contain links (within parentheses and brackets), and then filters out raw localhost links found in text.
For reference, see https://guides.github.com/features/mastering-markdown/#syntax (scroll down to Links)
Issue #7946
Follow up to PR #9099