Add keyboard support to amp-social-share #9215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmh287
force-pushed
the
amp-social-share_keyboard
branch
from
9c4ed76
to
f423a24
Compare
aghassemi
suggested changes
May 10, 2017
| @@ -96,13 +97,35 @@ class AmpSocialShare extends AMP.BaseElement { | |||
| ? '_top' : '_blank'; | |||
| }); | |||
|
|
|||
| this.element.setAttribute('role', 'link'); | |||
| this.element.setAttribute('role', 'button'); | |||
There was a problem hiding this comment.
let's set tabindex to 0 if it is not provided by author already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds keyboard support to
amp-social-share.amp-social-shareis focused will activate the element as a click wouldPartial for #8810
/to @aghassemi