Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure BindEvaluator always exists #9229

Merged
merged 1 commit into from
May 9, 2017
Merged

Make sure BindEvaluator always exists #9229

merged 1 commit into from
May 9, 2017

Conversation

dreamofabear
Copy link

Fixes #9228.

  • bind.addBindings isn't called on pages with 0 bindings.

/to @kmh287

@dreamofabear dreamofabear requested a review from kmh287 May 9, 2017 19:20
@kmh287
Copy link
Contributor

kmh287 commented May 9, 2017

Aren't all these changes in #8956?

@dreamofabear
Copy link
Author

Yea, I'm going to hold off on merging that for few more days. Want to verify that #9154 is fixed first.

kmh287
kmh287 approved these changes May 9, 2017
View reviewed changes
Copy link
Contributor

@kmh287 kmh287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, LGTM

@dreamofabear dreamofabear merged commit 1e6432d into ampproject:master May 9, 2017
@dreamofabear dreamofabear deleted the bind-evaluator-init branch May 9, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmh287 kmh287 kmh287 approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dreamofabear @kmh287 @googlebot @ampprojectbot