Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dep-check error log #9236

Merged
merged 1 commit into from
May 9, 2017
Merged

Fix dep-check error log #9236

merged 1 commit into from
May 9, 2017

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented May 9, 2017

dep-check error log is not outputting correct information.
I get:

TypeError: Cannot read property 'log' of undefined
    at red (/Users/zhouyx/amphtml/build-system/tasks/dep-check.js:37:27)

@zhouyx zhouyx requested a review from erwinmombay May 9, 2017 22:21
@zhouyx zhouyx merged commit 9e9af27 into ampproject:master May 9, 2017
@zhouyx zhouyx deleted the fix-dep-check-error branch May 9, 2017 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouyx @erwinmombay @googlebot @ampprojectbot