Allow specifying cookie name for CID. #9239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
May 10, 2017
| setCookie(window, 'url-abc', 'cid-for-abc'); | ||
| // Make sure cookie does not exist | ||
| setCookie(window, 'url-xyz', ''); | ||
| return expandAsync('?a=CLIENT_ID(abc,,url-abc)&b=CLIENT_ID(xyz,,url-xyz)', |
There was a problem hiding this comment.
What does scope do when there's a cookie name provided?
There was a problem hiding this comment.
cookieName is only used when a cookie is written. scope is still used for all other thing, for e.g., cidOnCache = sha384(baseCid + scope + domain)
|
Is there an issue tracking docs updates at https://github.com/ampproject/amphtml/blob/master/spec/amp-var-substitutions.md#client-id-arguments ? |
|
@rudygalfi updated in the next PR: #9281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8847