Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-bind: Cleanup of integration tests #9316

Merged
merged 3 commits into from May 16, 2017
Merged

amp-bind: Cleanup of integration tests #9316

merged 3 commits into from May 16, 2017

Conversation

kmh287
Copy link
Contributor

@kmh287 kmh287 commented May 12, 2017 •
edited

  • Moved the integration tests back to one file
  • Renamed fixture files for consistency

/to @choumx . Once this is in, would it be all right for me to edit the GFI to incorporate what we learned from the first successful PR?

@kmh287 kmh287 requested a review from dreamofabear May 12, 2017 19:55
dreamofabear
dreamofabear approved these changes May 16, 2017
View reviewed changes
Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks for cleaning this up.

@kmh287 kmh287 merged commit 88f19c2 into ampproject:master May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kmh287 @dreamofabear @googlebot @ampprojectbot