amp-ima-video: Markdown README for project #9336
Conversation
Fixed IMA SDK link. Really fixed IMA SDK link. Fixed again. Added space Fixed overvie wheader. Removed slash file.
| </tr> | ||
| <tr> | ||
| <td width="40%"><strong>Availability</strong></td> | ||
| <td>Experiment</td> |
There was a problem hiding this comment.
Please change "Experiment" to "Experimental"
| </tr> | ||
| <tr> | ||
| <td class="col-fourty"><strong><a href="https://www.ampproject.org/docs/guides/responsive/control_layout.html">Supported Layouts</a></strong></td> | ||
| <td>fixed, responsive</td> |
There was a problem hiding this comment.
According to the validator, this component supports: fill, fixed, fixed-height, nodisplay, responsive.
Please correct the list of supported layouts.
There was a problem hiding this comment.
I missed that in the validator - I tested the others and they don't work, so I removed them from the validator.
| width=640 height=360 layout="responsive" | ||
| data-src="https://s0.2mdn.net/4253510/google_ddm_animation_480P.mp4" | ||
| data-tag="https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/124319096/external/ad_rule_samples&ciu_szs=300x250&ad_rule=1&impl=s&gdfp_req=1&env=vp&output=vmap&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ar%3Dpremidpost&cmsid=496&vid=short_onecue&correlator=" | ||
| data-poster="path/to/poster.png" |
|
|
||
| ## Overview | ||
|
|
||
| You can use the `amp-ima-video` component to embed an IMA SDK enabled video |
There was a problem hiding this comment.
- Add link to the IMA SDK
- Rewrite the second sentence (and make it as a paragraph) with these minor tweaks:
To embed a video, provide a source URL for your content video (data-src) and an ad tag (data-tag), which is a URL to a VAST-compliant ad response (for examples, see IMA Sample Tags).
|
|
||
| **data-src** (required) | ||
|
|
||
| The URL of your content video. |
There was a problem hiding this comment.
Either: "The URL of your interactive media ad." or "The URL of your video content."
| <table> | ||
| <tr> | ||
| <td width="40%"><strong>Description</strong></td> | ||
| <td>A video player with an integration of the |
There was a problem hiding this comment.
Rewrite as:
Embeds a video player for instream video ads that are integrated with the IMA SDK.
| **data-tag** (required) | ||
|
|
||
| The URL for your VAST ad document. | ||
|
|
There was a problem hiding this comment.
| **data-tag** (required) | ||
|
|
||
| The URL for your VAST ad document. | ||
|
|
There was a problem hiding this comment.
What about the data-poster tag that you have in your sample? Should that be listed as an attribute, like the following:
data-poster (optional)
An image for the frame to be displayed before video playback has started. By default, the first frame is displayed.
| <td>Embeds a video player for instream video ads that are integrated with | ||
| the | ||
| <a href="https://developers.google.com/interactive-media-ads/docs/sdks/html5/">IMA SDK</a> | ||
| </td> |
|
|
||
| You can use the `amp-ima-video` component to embed an <a | ||
| href="https://developers.google.com/interactive-media-ads/docs/sdks/html5/">IMA | ||
| SDK</a>enabled video player. To embed a video, provide a source URL for your |
There was a problem hiding this comment.
Also, please start "To embed" on a new line, that is, as a new paragraph.
|
|
||
| This element includes | ||
| [common attributes](https://www.ampproject.org/docs/reference/common_attributes) | ||
| extended to AMP components |
| <td width="40%"><strong>Description</strong></td> | ||
| <td>Embeds a video player for instream video ads that are integrated with | ||
| the | ||
| <a href="https://developers.google.com/interactive-media-ads/docs/sdks/html5/">IMA SDK</a>, |
There was a problem hiding this comment.
Whoops, sorry :) Fixed.
|
FYI just merged upstream/master into my branch to try to resolve Travis issue. |
ghost
merged commit 
Adds md file for amp-ima-video project.