Add a vendor filter to analytics-vendors.amp.html for easier testing. #9389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avimehta
reviewed
May 22, 2017
build-system/app.js
Outdated
| var ads = file.match(new RegExp('<(amp-ad|amp-embed) [^>]*[\'"]' | ||
| + req.query.type + '[\'"][^>]*>([\\s\\S]+?)<\/(amp-ad|amp-embed)>', 'gm')); | ||
| file = file.replace( | ||
| /<body>[\s\S]+<\/body>/m, '<body>' + ads.join('') + '</body>'); | ||
| } | ||
|
|
||
| // Extract amp-ad for the given 'type' specified in URL query. |
| 1. "optout": if needed. We currently don't have a great opt-out system, so please reach out to help us design one that works well for you. | ||
| 1. An example in the [examples/analytics-vendors.amp.html](../../examples/analytics-vendors.amp.html) | ||
| 1. A line for your analytics service in the 'type' attribute section of the [amp-analytics](amp-analytics.md) usage reference. | ||
| 1. Test the new example you put in [examples/analytics-vendors.amp.html](../../examples/analytics-vendors.amp.html) to ensure the hits from the example are working as expected. For example, the data needed is being collected and displayed in your analytics dashboard. |
There was a problem hiding this comment.
optional: say something about type parameter for the example file?
There was a problem hiding this comment.
the dropdown UI is intuitive, isn't it? :-)
build-system/app.js
Outdated
| var ads = file.match(new RegExp('<(amp-ad|amp-embed) [^>]*[\'"]' | ||
| + req.query.type + '[\'"][^>]*>([\\s\\S]+?)<\/(amp-ad|amp-embed)>', 'gm')); | ||
| file = file.replace( | ||
| /<body>[\s\S]+<\/body>/m, '<body>' + ads.join('') + '</body>'); | ||
| } | ||
|
|
||
| // Extract amp-ad for the given 'type' specified in URL query. | ||
| if (req.path.indexOf('/examples/analytics-vendors.amp.html') == 0 && req.query.type) { | ||
| var analytics = file.match(new RegExp('<amp-analytics [^>]*[\'"]' |
There was a problem hiding this comment.
optional: move the creation of regex out to a function?
| <form action="analytics-vendors.amp.html" method="get" target="_top"> | ||
| <label for="filter">Vendor filter</label> | ||
| <select id="filter" name="type"> | ||
| <option>[Select a vendor]</option> |
There was a problem hiding this comment.
It is not clear exactly why one needs to select a vendor. Maybe put it somewhere?
"Select a vendor to show config for that vendor." or something along these lines. I initially thought that selecting a type will allow you to run only that analytics type.
There was a problem hiding this comment.
your initial thought is actually right
|
@avimehta PTAL |
avimehta
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.