Only error report request's origin for privacy #9446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since user private data can appear anywhere in the URL's request, let's only report the origin of the request when an error happens. Also converts this to an expected error, since there's really nothing we can do about a network failure.
|
Ping. |
erwinmombay
approved these changes
May 23, 2017
|
Post-merge 👍, I'll get to it in time next time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since user private data can appear anywhere in the URL's request, let's
only report the origin of the request when an error happens.
Also converts this to an expected error, since there's really nothing we
can do about a network failure.
Fixes #7585.