Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable printState in development, not just local dev #9460

Merged
merged 3 commits into from May 24, 2017
Merged

Enable printState in development, not just local dev #9460

merged 3 commits into from May 24, 2017

Conversation

kmh287
Copy link
Contributor

@kmh287 kmh287 commented May 22, 2017

/to @choumx

@kmh287 kmh287 requested a review from dreamofabear May 22, 2017 13:04
dreamofabear
dreamofabear reviewed May 22, 2017
View reviewed changes
Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this property get renamed when compiled?

@kmh287
Copy link
Contributor Author

kmh287 commented May 23, 2017

Doesn't look like it. I was able to use it by name with minified js

@kmh287 kmh287 merged commit ce1d106 into ampproject:master May 24, 2017
@kmh287 kmh287 mentioned this pull request May 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kmh287 @dreamofabear @googlebot @ampprojectbot