Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tests to access local version of web worker. #9475

Merged
merged 8 commits into from May 26, 2017
Merged

Allow tests to access local version of web worker. #9475

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dec7b54
opt_minified
kmh287 May 22, 2017
f2403ab
fix arg for localDev
kmh287 May 22, 2017
ce6b753
pr comments
kmh287 May 23, 2017
59016f8
pr comments
kmh287 May 24, 2017
65815d7
revert
kmh287 May 24, 2017
4a51acf
pr comments
kmh287 May 24, 2017
2e8b513
revert changes to test-server and test-bind-impl
kmh287 May 26, 2017
329da81
cleanup
kmh287 May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/web-worker/amp-worker.js
View file
Open in desktop
Expand Up @@ -74,9 +74,10 @@ class AmpWorker {
loc = win.testLocation;
}
// Use RTV to make sure we fetch prod/canary/experiment correctly.
const useRtvVersion = !getMode().localDev && !getMode().test;
const useLocal = getMode().localDev || getMode().test;
const useRtvVersion = !useLocal;
const url = calculateEntryPointScriptUrl(
loc, 'ww', getMode().localDev, useRtvVersion);
loc, 'ww', useLocal, useRtvVersion);
dev().fine(TAG, 'Fetching web worker from', url);

/** @private {Worker} */
Expand Down