New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animations: apply calc/var transforms to keyframes and timing #9496
Conversation
"transform": "translateX(0px)" | ||
} | ||
"keyframes": [ | ||
{"transform": "translateY(var(--start-y))", "opacity": "var(--start-o)"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack!
@@ -17,6 +17,20 @@ | |||
const FINAL_URL_RE = /^(data|https)\:/i; | |||
const DEG_TO_RAD = 2 * Math.PI / 360; | |||
const GRAD_TO_RAD = Math.PI / 200; | |||
const VAR_CSS_RE = /calc|var|url/i; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/calc(|var(|url(/i
to avoid false positives likes font-variant
CSS property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Though false positives here are very benign.
this.parsedCssCache_ = map(); | ||
|
||
/** @private {?Element} */ | ||
this.current_ = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: currentTarget_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
/cc @lexandera |
Partial for #9129.