Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/delete untracked files #9510

Merged
merged 1 commit into from May 25, 2017
Merged

Fix/delete untracked files #9510

merged 1 commit into from May 25, 2017

Conversation

muxin
Copy link
Contributor

@muxin muxin commented May 23, 2017

Tried git rm -r --cached . and found several files that shouldn't be committed to repo.
@erwinmombay correct me if I'm wrong

@muxin muxin requested a review from erwinmombay May 23, 2017 23:04
@muxin
Copy link
Contributor Author

muxin commented May 23, 2017 •
edited

Do we need to commit build-system/runner/dist/runner.jar? If we do, then we need to correct the .gitignore

@muxin
Copy link
Contributor Author

muxin commented May 24, 2017

@erwinmombay PTAL

@erwinmombay
Copy link
Member

yes runner.jar should be committed

@muxin muxin merged commit cb40239 into ampproject:master May 25, 2017
@muxin muxin deleted the fix-ignored-files branch May 25, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@muxin @erwinmombay @googlebot @ampprojectbot