Don't do a dist in the integration_tests shard for PRs #9530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
approved these changes
May 24, 2017
| @@ -361,22 +361,22 @@ function main(argv) { | |||
| } | |||
|
|
|||
| if (process.env.BUILD_SHARD == "integration_tests") { | |||
| if (buildTargets.has('RUNTIME')) { | |||
| command.buildRuntime(); | |||
| command.runIntegrationTests(); | |||
There was a problem hiding this comment.
I think this will also disable integration tests on Saucelabs. Check out this sample master build that runs pr-check.js: https://travis-ci.org/ampproject/amphtml/jobs/235767902
There was a problem hiding this comment.
That is a separate call, and happens in runAllCommands(). See https://github.com/ampproject/amphtml/blob/master/build-system/pr-check.js#L270
dreamofabear
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't run the integration tests for PRs, so don't do a dist either.
#9500