Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter bad first-paint values. #9532

Merged
merged 2 commits into from May 24, 2017
Merged

Conversation

cramforce
Copy link
Member

Chrome sometimes reports 1 or 0, but those values are never realistic, so lets throw them away.

PR does some light refactoring for readability.

Chrome sometimes reports 1 or 0, but those values are never realistic, so lets throw them away.

PR does some light refactoring for readability.
Copy link
Contributor

@lannka lannka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I suppose you're only talking about the legacy API.

@cramforce cramforce merged commit bfec210 into ampproject:master May 24, 2017
@cramforce cramforce deleted the fp-quality branch May 24, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants