Move messaging.js to NPM package #9547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
reviewed
May 25, 2017
| @@ -14,7 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| import {Messaging, WindowPortEmulator, parseMessage} from './messaging'; | |||
| import {Messaging, WindowPortEmulator, parseMessage} from 'messaging'; | |||
There was a problem hiding this comment.
Can you explain how "messaging" name here is getting resolved? Also, what will this look like when imported from the "amp-viewer" repo?
There was a problem hiding this comment.
it's going to be taken straight from the file itself (not from npm)
|
shouldn't we be adding milestones to issues only? |
dvoytenko
suggested changes
May 26, 2017
| @@ -58,9 +55,10 @@ export function parseMessage(message) { | |||
| if (message.charAt(0) != '{') { | |||
| return null; | |||
| } | |||
| return /** @type {?Message} */ (tryParseJson(message) || null); | |||
| return /** @type {?Message} */ (JSON.parse(/** @type {string} */ (message))); | |||
There was a problem hiding this comment.
This is a big change - the previous version failed silently. You should probably preserve that. Anyone can send a message and it's not guaranteed to be what we expect. So it's best to shield ourselves and overspam error logs.
| Messaging, | ||
| WindowPortEmulator, | ||
| parseMessage, | ||
| } from '../messaging/messaging.js'; |
|
@chenshay Could you pls also reference the PR for |
dvoytenko
approved these changes
May 26, 2017
chenshay
force-pushed
the
npm
branch
2 times, most recently
from
6ac9dcc
to
9b3e477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #9528
it is being used here: https://github.com/ampproject/amp-viewer/blob/master/src/amp-viewer-host.js