Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase amp-bind integration test timeout #9558

Merged
merged 2 commits into from May 25, 2017
Merged

Increase amp-bind integration test timeout #9558

merged 2 commits into from May 25, 2017

Conversation

dreamofabear
Copy link

These tests were passing previously as unit tests with 10s timeout, so this may fix timeouts on master.

@dreamofabear dreamofabear requested a review from rsimha May 25, 2017 19:16
rsimha
rsimha approved these changes May 25, 2017
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default timeout for merges on master is already 10s, and the integration tests are not run for PRs. So if this is targeted at making master green, simply removing the timeout will do the job.

Is the intention to have this change apply to local runs also?

@dreamofabear
Copy link
Author

Good idea, done.

@dreamofabear dreamofabear merged commit 165ce07 into master May 25, 2017
@dreamofabear dreamofabear deleted the bind-integration-timeout branch May 25, 2017 20:55
@rsimha
Copy link
Contributor

rsimha commented May 26, 2017

Seems like the integration tests are still timing out on master even after going up to 10s.

@dreamofabear
Copy link
Author

#9571

@dreamofabear dreamofabear mentioned this pull request May 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dreamofabear @rsimha @googlebot @ampprojectbot