Should show amp-app-banner in non-embedded firefox ios #9573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually verified in firefox ios |
aghassemi
approved these changes
May 26, 2017
There was a problem hiding this comment.
isSafari() code is hilarious. :) also @cramforce, I guess Firefox's marketing team doesn't see thousands of PRs like this from the web community...
cramforce
approved these changes
May 26, 2017
| @@ -70,7 +70,7 @@ export class Platform { | |||
| * @return {boolean} | |||
| */ | |||
| isFirefox() { | |||
| return /Firefox/i.test(this.navigator_.userAgent) && !this.isEdge(); | |||
| return /Firefox|FxiOS/i.test(this.navigator_.userAgent) && !this.isEdge(); | |||
There was a problem hiding this comment.
I realize we do for Chrome, but we really shouldn't treat Chrome and Firefox on iOS as Chrome and Firefox. I guess the precedent wins here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9566