Fix most amp-bind integration tests #9577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmh287
approved these changes
May 26, 2017
| const impl = carousel.implementation_; | ||
| expect(slideNum.textContent).to.equal('0'); | ||
| impl.go(1, /* animate */ false); | ||
| const nextSlideButton = |
|
@kmh287 Appreciate the initiative but merge was a bit premature. Firefox tests are fixed but some failures on Chrome 45 and Chrome Mobile 44 still: https://travis-ci.org/ampproject/amphtml/jobs/236386931 😭 |
|
Sorry, got too excited. 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #9571. Fix and un-skip a bunch of tests.
amp-carouseltest to not require internal APIs. Also, flakiness fixed by making sure it gets laid out.amp:bind:initializeevent firing before the listener was added.All un-skipped tests now pass locally on Firefox 53 on OS X. A few are left.
/to @kmh287