Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using IOS elastic scroll when slidescroll takes over animation (Only for the NON SNAP-POINTS flow) #9668

Merged
merged 2 commits into from
Jun 1, 2017
Merged

Stop using IOS elastic scroll when slidescroll takes over animation (Only for the NON SNAP-POINTS flow) #9668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
022e4fd
removing overflow touch on no-scroll for ios
camelburrito May 31, 2017
569fca3
Stop using IOS elastic scroll when slidescroll takes over animation (…
camelburrito Jun 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions extensions/amp-carousel/0.1/amp-carousel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,11 @@ amp-carousel .amp-carousel-button.amp-disabled {
.i-amphtml-slidescroll-no-snap .i-amphtml-slide-item {
scroll-snap-coordinate: none !important;
}

.i-amphtml-slidescroll-no-snap.i-amphtml-slides-container.i-amphtml-no-scroll {
-webkit-overflow-scrolling: auto !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to cause problems for any iframes inside the carousel.

Copy link
Contributor Author

@camelburrito camelburrito Jun 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it won't - this is only enabled when .i-amphtml-no-scroll class is present , which means our script already disabled scrollbar and took over the animation

}

/* End SlideScroll */

/* Begin ScrollableCarousel */
Expand Down