Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'gulp css' and remove the now redundant 'gulp build --css-only' #9741

Merged
merged 3 commits into from Jun 6, 2017
Merged

Fix 'gulp css' and remove the now redundant 'gulp build --css-only' #9741

merged 3 commits into from Jun 6, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jun 6, 2017

This PR does the following:

  1. Makes sure that gulp css also builds CSS within extensions
  2. Removes the now redundant --css-only flag to gulp build, now that there's no difference between gulp css and gulp build --css-only
  3. Updates gulp dist to not need any prerequisite css build steps. You can now do gulp clean followed by gulp dist
  4. Updates gulp watch to not need any prerequisite css build steps, and fixes it so it's not missing any dependencies

Fixes #9640

@rsimha rsimha merged commit 58d6b89 into ampproject:master Jun 6, 2017
@rsimha rsimha deleted the 2017-06-06-CSSBuild branch June 6, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All common gulp commands should be able to run from a clean state
5 participants