Skip unit tests for PRs containing only integration test changes #9771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @choumx, @erwinmombay |
erwinmombay
approved these changes
Jun 7, 2017
erwinmombay
reviewed
Jun 7, 2017
| * @return {boolean} | ||
| */ | ||
| function isIntegrationTest(filePath) { | ||
| if (filePath.startsWith('test/integration/')) return true; |
There was a problem hiding this comment.
no need for if statement just do:
return filePath.startsWith('test/integration/');
There was a problem hiding this comment.
Coming up in a different PR.
|
This was a success. See https://travis-ci.org/ampproject/amphtml/jobs/240510675. Travis runs for PRs containing just integration test changes reduced by half, to about 9 mins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we run integration tests only on master, this PR will speed up Travis PR builds if all you are doing is changing / disabling / enabling an integration test.
Fixes #9772