Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMP A4A Experiment Cleanup #9777

Merged
merged 1 commit into from Jun 7, 2017
Merged

AMP A4A Experiment Cleanup #9777

merged 1 commit into from Jun 7, 2017

Conversation

keithwrightbos
Copy link
Contributor

Clean up launched behavior change experiments:

  • a4a-fie-unlayout-enabled which allowed for disabling feature change where AMP creatives are not removed within unlayoutCallback
  • a4a-disable-cryptokey-viewer-check which allowed for disabling feature change where crypto public key fetch is delayed until page is not in a prerender state

/cc @ampproject/a4a

@keithwrightbos keithwrightbos self-assigned this Jun 7, 2017
bradfrizzell
bradfrizzell approved these changes Jun 7, 2017
View reviewed changes
Copy link
Contributor

@bradfrizzell bradfrizzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keithwrightbos keithwrightbos merged commit 907c18a into ampproject:master Jun 7, 2017
@keithwrightbos keithwrightbos deleted the a4a_fie_exp_cleanup branch June 7, 2017 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradfrizzell bradfrizzell bradfrizzell approved these changes

Assignees

@keithwrightbos keithwrightbos

Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@keithwrightbos @bradfrizzell @googlebot @ampprojectbot