Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMP Sidebar V1: Skeleton'd the files for the feature #9784

Merged
merged 11 commits into from Jun 8, 2017
Merged

AMP Sidebar V1: Skeleton'd the files for the feature #9784

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9392fb5
Made a skeleton of all of the required files
torch2424 Jun 7, 2017
5cba7b5
Removed the test output,a nd updated the gulp file
torch2424 Jun 7, 2017
8f8f4cf
Added some more skeleton to the main sidebar .js file
torch2424 Jun 7, 2017
3a5dbb2
Updated the copyright year
torch2424 Jun 7, 2017
3248809
Fixed Travis Linting errors
torch2424 Jun 7, 2017
857f7cd
Fixed the typo on the alias declaration
torch2424 Jun 7, 2017
adbd07d
Adding sidebar v1 exception to the dep check
torch2424 Jun 7, 2017
ce2b1ea
Fixed PR comments
torch2424 Jun 7, 2017
6883834
Added a note about declareExtensionVersionAlias, and declared versions
torch2424 Jun 8, 2017
6a06278
Fixed Sidebar 0.1 tests
torch2424 Jun 8, 2017
394c020
Fixed the gulpfile typo
torch2424 Jun 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion extensions/amp-sidebar/0.1/amp-sidebar.js
View file
Open in desktop
Expand Up @@ -323,4 +323,6 @@ export class AmpSidebar extends AMP.BaseElement {
}
}

AMP.registerElement('amp-sidebar', AmpSidebar, CSS);
AMP.extension('amp-sidebar', '0.1', AMP => {
AMP.registerElement('amp-sidebar', AmpSidebar, CSS);
});
4 changes: 3 additions & 1 deletion extensions/amp-sidebar/1.0/amp-sidebar.js
View file
Open in desktop
Expand Up @@ -34,4 +34,6 @@ export class AmpSidebar extends AMP.BaseElement {
}
}

AMP.registerElement('amp-sidebar', AmpSidebar, CSS);
AMP.extension('amp-sidebar', '1.0', AMP => {
AMP.registerElement('amp-sidebar', AmpSidebar, CSS);
});
4 changes: 4 additions & 0 deletions gulpfile.js
View file
Open in desktop
Expand Up @@ -168,6 +168,10 @@ function declareExtension(name, version, hasCssOrOptions, opt_noTypeCheck,
}

/**
* This function is used for declaring deprecated extensions. It simply places the current
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

* version code in place of the latest versions.
* This has the ability to break an extension verison, so please be sure that this is
* the correct to use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "the correct one to use"?

* @param {string} name
* @param {string} version E.g. 0.1
* @param {string} lastestVersion
Expand Down