Make bind integration tests less flaky (the remix) #9788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Jun 7, 2017
| <amp-img src="http://www.google.com/image1" height="200" width="200"></amp-img> | ||
| <amp-img src="http://www.google.com/image1" height="200" width="200"></amp-img> | ||
| <amp-img src="http://www.foo.com/image" height="200" width="200"></amp-img> | ||
| <amp-img src="http://www.foo.com/image" height="200" width="200"></amp-img> |
There was a problem hiding this comment.
Curious: Why the intentionally invalid images?
There was a problem hiding this comment.
Real, locally served images would avoid polluting the error log but it doesn't affect test correctness either way. Would be a good clean-up task or GFI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9786.
AmpFormServiceregistration forwith <amp-form>tests.bind-list.htmlvalidation error which caused failures on some browsers.Local saucelab runs are green with these changes.
/to @rsimha-amp /cc @camelburrito