Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedded examples to amp-accordion and amp-carousel #9795

Merged
6 commits merged into from Jun 8, 2017
Merged

Add embedded examples to amp-accordion and amp-carousel #9795

6 commits merged into from Jun 8, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 8, 2017

Added inline example to amp-accordion and amp-carousel per ampproject/amp.dev#141.

Also:

  • stylistic improvements
  • wording improvements

@ghost ghost requested a review from pbakaus June 8, 2017 15:12
Copy link
Contributor

@pbakaus pbakaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ghost ghost merged commit 7b72a63 into ampproject:master Jun 8, 2017
@ghost ghost deleted the add-embedded-examples2 branch June 8, 2017 15:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants